Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ripple SHOULDN'T follow the finger movement while holding #69

Open
taylorling opened this issue Oct 18, 2016 · 0 comments
Open

The ripple SHOULDN'T follow the finger movement while holding #69

taylorling opened this issue Oct 18, 2016 · 0 comments

Comments

@taylorling
Copy link

I am speaking as a designer here. We were using this library hoping to bring the ripple effect to pre-L devices, but I found out that the behavior is wrong in a sense that the ripple, when it happens, it should emit at the source of trigger, which shouldn't follow the finger when it is being tapped and hold.

Also the ripple should ensure that the four corners reach at the exact same time, this would mean when the ripple happens, the center point should also move so the 4 corners will meet the end at the exact same time.

These are the genuine behavior in Ripple effect in Material Design. Hopefully the author of the library can fix this to ensure everyone who is using this library is able to implement the right Material Design behavior.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant