-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convergence criteria #381
Comments
Hi @gaborantal, you're not the first to bring this up and I can see the appeal. In my personal opinion, since such things can be performed by using suggest-evaluate-register (#373) instead of How would you determine that the optimization procedure has converged? |
I wouldn't mind adding optional convergence criteria as an argument that can be passed at instantiation.
|
This is exactly what we need. However, your other mentioned option also looks great, and might be useful. |
From my project experiences, here are some termination criteria:
and we compose some terminations if possible |
Is your feature request related to a problem? Please describe.
Currently, only fixed number of iteration can be set to the optimizer. However, a convergence criteria would be useful.
Describe the solution you'd like
By using a convergence criteria, a maximum number of steps OR the convergence criteria could be used to stop the iteration (whichever happens first). The reason why the iteration stopped should be available after the execution.
Are you able and willing to implement this feature yourself and open a pull request?
If anyone can do this issue, that would be great, however, I'm also fine with doing it myself in a form of PR.
The text was updated successfully, but these errors were encountered: