Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmit tests to validate platform definitions #33

Open
aiuto opened this issue Oct 1, 2021 · 1 comment
Open

Add presubmit tests to validate platform definitions #33

aiuto opened this issue Oct 1, 2021 · 1 comment
Assignees
@aiuto
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee)

Comments

@aiuto
Copy link
Contributor

aiuto commented Oct 1, 2021

  • A smoke test to make sure the BUILD files parse
  • bonus points for producing a listing of all the defined cpu & OS values
    • perhaps the listing could be generated docs that we push back to a README
@aiuto aiuto added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Apr 11, 2022
@aiuto
Copy link
Contributor Author

aiuto commented Apr 11, 2022

We might not need this on CI at all. We should run bazel build ... before any commit to see things parse. There is not enough to break. I'm leaving it open as a reminder that we have no CI run.

@aiuto aiuto added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiuto aiuto

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aiuto @gregestren