Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding housing schema #5

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Adding housing schema #5

merged 5 commits into from
Jun 21, 2024

Conversation

JTA2020
Copy link
Contributor

@JTA2020 JTA2020 commented Jun 21, 2024

This is to supplement the core schema with the extended attributes to support the housing initiative

annikaLiving
annikaLiving requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@annikaLiving annikaLiving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few space and bracket updates.

schemas/definitions/housing-permit-schema.json Outdated Show resolved Hide resolved
schemas/definitions/housing-permit-schema.json Outdated Show resolved Hide resolved
schemas/definitions/housing-permit-schema.json Outdated Show resolved Hide resolved
@JTA2020 JTA2020 self-assigned this Jun 21, 2024
JTA2020 and others added 4 commits June 21, 2024 11:46
@JTA2020 @annikaLiving
Update schemas/definitions/housing-permit-schema.json
435ad86 
Co-authored-by: Annika <32690119+annikaLiving@users.noreply.github.com>
@JTA2020 @annikaLiving
Update schemas/definitions/housing-permit-schema.json
cedc4fc 
Co-authored-by: Annika <32690119+annikaLiving@users.noreply.github.com>
@JTA2020 @annikaLiving
Update schemas/definitions/housing-permit-schema.json
455d7d0 
Co-authored-by: Annika <32690119+annikaLiving@users.noreply.github.com>
@JTA2020
Update housing-permit-schema.json
d8fe1f9
annikaLiving
annikaLiving approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@annikaLiving annikaLiving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and aligned.

annikaLiving
annikaLiving approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@annikaLiving annikaLiving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates now align the items

@abschwenker abschwenker requested a review from a team June 21, 2024 19:23
mishraomp
mishraomp approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JTA2020 JTA2020 merged commit bca870e into main Jun 21, 2024
4 checks passed
@JTA2020 JTA2020 deleted the jta-housing-schema branch June 21, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annikaLiving annikaLiving annikaLiving approved these changes

@mishraomp mishraomp mishraomp approved these changes

Assignees

@JTA2020 JTA2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JTA2020 @mishraomp @annikaLiving