-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use URL instead of base64-encoded payload for deep link #504
Comments
Possibly superseeded by #513 |
I think we need to talk more about invitation URLs and how payloads are retrieved. I still don't fully understand why we process HTTP Header ( |
This issue was logged specifically for the issue relating to deep-link URLs exceeding the 2048 character limit. If we switch our pattern to using short-lived connections we should be able to also resolve this. We may still want to chat as I am not 100% sure I follow the location redirect URL and custom protocols bit. |
Thanks to the BC Wallet team for implementing the new deep-link handler - we should update our code to generate the deep link using the following format: |
Handling here #557 |
When proof-requests grow in size, the resulting deep-link can grow to over 2048 characters, causing the payload to be truncated when sent over to BC Wallet (2048 characters is the size limit for URLs) which will then fail to process the request as the decoded output is a malformed JSON.
One way to fix this would be to use a URL/shortened URL instead of the base64 encoded presentation-request, but we are unsure on whether this will work out-of-the-box or not (attempts seem to indicate this will not work as-is).
@jleach @cvarjao does a change need to get into BC Wallet to handle this, or are we maybe using the
bcwallet://...?c_i=https://my-url.com
(or similar OOB) syntax incorrectly with the url?The text was updated successfully, but these errors were encountered: