Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm Chart] Add ACA-Py as chart component/dependency #315

Merged
merged 22 commits into from
Aug 23, 2023
Merged

[Helm Chart] Add ACA-Py as chart component/dependency #315

merged 22 commits into from
Aug 23, 2023

Conversation

i5okie
Copy link
Contributor

@i5okie i5okie commented Aug 14, 2023 •
edited
Loading

Add ACA-Py as a Chart component

  • Add ACA-Py as a Chart component configurable through updated Values file
  • Document Values file and create a Readme
  • Add Postgres chart dependency for agent database

Addresses the following issues:

@i5okie
update version, add postgres dependency
c5accfe 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
update dependencies
100a08e 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
add urls
3387ac5 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
allow connection between baked-in agent and controller
9f2cbe8 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
allow connection between baked-in agent and postgresql
a3f7388 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
allow external traffic to connect to agent
3bdc329 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
add agent hosts to ingress
756fa20 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
expose controller envvars to be set in Values
d30d5f2 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
cleanup, use common helper libary, add agent helpers
2180582 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
cleanup controller secret
89a8093 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
cleanup, use updated helper code, use common lib
dfdd1e9 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
add agent resources
59ebf87 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
cleanup existing values, add agent dependency, add documentation
b1f0c0a 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
Add Readme
8a0ad18 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie i5okie requested a review from esune August 14, 2023 23:36
@i5okie i5okie changed the base branch from main to 2.0-development August 14, 2023 23:37
@i5okie i5okie changed the title [Helm Chart] Add ACA-Py as chart component/dependency, Add [Helm Chart] Add ACA-Py as chart component/dependency Aug 15, 2023
esune
esune requested changes Aug 16, 2023
View reviewed changes
charts/vc-authn-oidc/README.md Outdated Show resolved Hide resolved
charts/vc-authn-oidc/README.md Show resolved Hide resolved
charts/vc-authn-oidc/README.md Show resolved Hide resolved
charts/vc-authn-oidc/README.md Show resolved Hide resolved
charts/vc-authn-oidc/templates/agent/deployment.yaml Outdated Show resolved Hide resolved
charts/vc-authn-oidc/templates/deployment.yaml Outdated Show resolved Hide resolved
@i5okie
Merge branch '2.0-development' into feature/issue-296-acapy-agent
b8449e5
@i5okie
Merge branch '2.0-development' into feature/issue-296-acapy-agent
1c0a6d9
@i5okie
Update install instructions to use vc-authn-oidc helm repo
1ccf72f 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
Use acapy.host for agent endpoint. fix argfile location
e8ee021 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
Prepend selected protocol for URLs, update Readme, use internal agent…
beebcdd 
… admin url

Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
@i5okie
Define and use
84bd577 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
esune
esune requested changes Aug 23, 2023
View reviewed changes
charts/vc-authn-oidc/templates/agent/deployment.yaml Outdated
--inbound-transport http '0.0.0.0' {{ .Values.acapy.service.httpPort }} \
--outbound-transport http \
--admin '0.0.0.0' {{ .Values.acapy.service.adminPort }} \
--endpoint {{ include "acapy.agent.url" . }} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the ACAPY_ENDPOINT environment variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@i5okie
Use ACAPY_ENDPOINT envvironment variable instead of command flag
661ba0b 
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
esune
esune approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's test it out in the wild 👍🏻

@esune esune merged commit 2baf012 into bcgov:2.0-development Aug 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i5okie @esune