Ensure user authentication sessions are independent #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #362
Previously, the user authentication sessions was always leaning on the same "fake user" in the
Userinfo
database to store data temporarily. This lead to issues when multiple concurrent authentication requests were attempted: data from a user authentication session would pollute other user authentication sessions, leaking information.The fix involved:
VCUserinfo
class that overrides the methods inUserinfo
responsible for returning datasubject_identifier
, the generation of theclaims
object was updated to only include thesub
claim if the proof-request defines one, and ensuring the token endpoint accounts for the custom sub, if present.