Remove handshake protocols again temporarily #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
|
Added #583 to really sort this out when there's time. |
esune
approved these changes
Jul 16, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OOB proof pydantic model was missing handshake_protocols so that was never getting outputted in the OOB message. Even though aca-py was returning it with
[]in there.#577 addressed this so it could be used in the event a VCAuth operator does want something in there.
Could have sworn I tried it out a bunch with BC Wallet after that but I must have misconfigured something because now if I turn on OOB I get an error when scanning in BC Wallet
If I set didcomm or connections in the handshake protocols then the wallet seems to spin on the connecting screen.
So something is either wrong in the Wallet or our OOB message setup when including handshake protocols and going back to the old situation where it is just missing from the output works.
Trying to troubleshoot other OOB issues in BC Wallet so one thing at a time and going to eliminate this error from the current situation.