Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use human-friendly values in query params #185

Closed
ekelen opened this issue May 6, 2020 · 3 comments
Closed

Use human-friendly values in query params #185

ekelen opened this issue May 6, 2020 · 3 comments
Assignees
Labels
api enhancement New feature or request help wanted Extra attention is needed

Comments

@ekelen
Copy link
Collaborator

ekelen commented May 6, 2020

Even if there is a UI (eventually) for each query parameter, it would be cool if users can also use intuitive string values for possible query params.

e.g. Instead of artifact_kinds=1 --> artifact_kinds=IPA
build_driver=4 --> build_driver=github

@ekelen ekelen added enhancement New feature or request api labels May 6, 2020
@moul
Copy link
Member

moul commented May 7, 2020

from what I can see, it should be already available: https://github.com/grpc-ecosystem/grpc-gateway/pull/314/files

I will check if I missed some configuration option

GitHub
parses enumeration strings and integer values range checks both the string and integer form

@moul moul self-assigned this May 7, 2020
@moul moul added the help wanted Extra attention is needed label May 7, 2020
@ekelen
Copy link
Collaborator Author

ekelen commented May 7, 2020

kk. Here is an example, maybe I'm not formatting the request properly.

curl -u AUTH "https://yolo.berty.io/api/build-list?artifact_kinds=APK"
{
  "code": 3,
  "message": "strconv.ParseInt: parsing \"APK\": invalid syntax"
}%

@moul moul mentioned this issue Oct 1, 2020
84 tasks
@moul
Copy link
Member

moul commented Oct 1, 2020

moved to #2

@moul moul closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants