Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CSS coherently throughout front #68

Closed
3 tasks
ekelen opened this issue Apr 17, 2020 · 1 comment
Closed
3 tasks

Use CSS coherently throughout front #68

ekelen opened this issue Apr 17, 2020 · 1 comment
Assignees
@ekelen
Labels
front

Comments

@ekelen
Copy link
Collaborator

ekelen commented Apr 17, 2020

Right now it's a mix of .scss global files (_variables.scss) and unscoped local .scss files (Header.scss), and inline styles in JSX. The naming conventions for classes also vary between files.

So, we need to:

  • Name custom (i.e. non-vendor) classes consistently throughout web codebase
  • Remove all inline styles except calculated color based on theme preference
  • All components should use same convention to import CSS, whether with 1-1 stylesheets (Header.js, Header.scss) or something else
@ekelen ekelen self-assigned this Apr 17, 2020
@ekelen ekelen changed the title Front: Use CSS coherently throughout front Use CSS coherently throughout front Apr 17, 2020
@moul moul added the front label Apr 22, 2020
@moul moul mentioned this issue Oct 1, 2020
Open
84 tasks
@moul
Copy link
Member

moul commented Oct 1, 2020

moved to #2

@moul moul closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekelen ekelen

Labels
front
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moul @ekelen