Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/tsp-forwarder: prevent overconsumption of CPU #24

Open
masiulaniec opened this issue Jul 9, 2015 · 0 comments
Open

cmd/tsp-forwarder: prevent overconsumption of CPU #24

masiulaniec opened this issue Jul 9, 2015 · 0 comments
Labels

Comments

@masiulaniec
Copy link
Contributor

GOMAXPROCS default is changing, see the proposal at https://golang.org/s/go15gomaxprocs

In response to this, I think cmd/tsp-forwarder should call runtime.GOMAXPROCS(1). It should be enough for everybody, because the heavy-lifting is done by cmd/tsp-poller and cmd/tsp-aggregator.

This is partially a security feature, because CPU consumption is affected by tsp-controller (think Filter rules), and therefore can be potentially compromised and used as a DoS attack vector.

@masiulaniec masiulaniec added the bug label Jul 9, 2015
@masiulaniec masiulaniec changed the title cmd/tsp-forwarder: hardcode GOMAXPROCS=1 cmd/tsp-forwarder: prevent overconsumption of CPU Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant