Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Maximised viewport on widescreen mode #320

Open
emileb opened this issue Jan 3, 2021 · 2 comments
Open

Suggestion: Maximised viewport on widescreen mode #320

emileb opened this issue Jan 3, 2021 · 2 comments
Labels
feature New feature

Comments

@emileb
Copy link
Contributor

emileb commented Jan 3, 2021

Not sure what you think but I think it looks good when the viewport is maximised when in widescreen mode.

I did a very hacky implementation, but was a bit confused with all the various size variables so it's probably not the correct method, but it seems to work for me:
emileb@8f8d1f6

Original:
device-2021-01-03-134143

Maximised:
device-2021-01-03-134236

@bibendovsky
Copy link
Owner

Unless you plan to add option to control the viewport's size it's better, for now, to leave this code as mobile-related.

@bibendovsky bibendovsky added the feature New feature label Jan 3, 2021
@emileb
Copy link
Contributor Author

emileb commented Jan 4, 2021

Unless you plan to add option to control the viewport's size it's better, for now, to leave this code as mobile-related.

Yep good idea, I'll add as an option and you can decide if it's suitable for upstream. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants