Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: profiler #16

Open
timotheecour opened this issue Nov 6, 2018 · 4 comments
Open

discussion: profiler #16

timotheecour opened this issue Nov 6, 2018 · 4 comments

Comments

@timotheecour
Copy link
Contributor

  • wondering if code profiler is out of scope for this project or whether there are opportunities for code reuse (eg visualization etc)

links

@samuelroy
Copy link
Collaborator

samuelroy commented Nov 6, 2018

I looked into nimprof and nim system/profiler.nim, it's interesting. I even thought it could be useful for solving our issues with code coverage when I saw the object system.StacktraceEntry which holds everything we need. Unfortunately the profiler has only a stacktrace object without any line number.

Sure we could work out a code profiler, starting by creating a chart out of nimprof results or creating our own profiler. But first it would be nice to have a proper code coverage tool.

@timotheecour
Copy link
Contributor Author

timotheecour commented Dec 31, 2018

Unfortunately the profiler has only a stacktrace object without any line number.

I'm fixing this in nim-lang/Nim#10119

Sure we could work out a code profiler, starting by creating a chart out of nimprof results or creating our own profiler

see also nim-lang/Nim#10132 which compares 4 profilers as applied to nim

But first it would be nice to have a proper code coverage tool.

of course

@samuelroy
Copy link
Collaborator

I'm fixing this in nim-lang/Nim#10119

Super interesting, I think it would be very helpful for what we're trying to do here.

@samuelroy
Copy link
Collaborator

@timotheecour : I've seen that nim-lang/Nim#10119 is unfortunately rejected.

Is there any plans to add line numbers to the stacktrace in lib/system/profiler.nim?

From your commits, it seems like a light addition and it might allow code coverage for any nim backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants