Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruff support #3

Closed
reece opened this issue Jul 17, 2023 · 11 comments · Fixed by #36
Closed

add ruff support #3

reece opened this issue Jul 17, 2023 · 11 comments · Fixed by #36
Assignees
Labels
keep alive exempt issue from staleness checks

Comments

@reece
Copy link
Member

reece commented Jul 17, 2023

See https://beta.ruff.rs/docs/configuration/

Decision at 2024-05-20 maintainers' meeting:

  • adopt ruff
  • drop pylint, pylint, isort, black
  • keep pyright as-is for now
  • Do the above in this repo initially, then propagate as separate issues
  • for now, separate ruff check and ruff format operations
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@reece
Copy link
Member Author

reece commented Sep 15, 2023

@ecalifornica : Seems like something that you'd be interested in

@github-actions github-actions bot removed the Stale label Sep 16, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Oct 16, 2023
@ecalifornica ecalifornica removed the stale Issue is stale and subject to automatic closing label Oct 16, 2023
@ecalifornica
Copy link
Member

Do we want to add this to the Makefile/PR checks?

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Nov 16, 2023
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2023
@reece reece reopened this Feb 19, 2024
@reece reece removed the stale Issue is stale and subject to automatic closing label Feb 19, 2024
@reece
Copy link
Member Author

reece commented Feb 19, 2024

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a onos.environ["GITHUB_TOKEN"]e-time event.

@jsstevenson
Copy link
Contributor

jsstevenson commented Mar 26, 2024

Would like to bump this for consideration (@reece, @korikuzma, others). We're now using Ruff in virtually all of our projects as the single source of linting and formatting, and I think we're pretty happy with it -- it's fast, easy to use, centrally configurable, and offers a wide array of available rules. I'm confident that it could replace most of the linting checks currently listed in pyproject.toml/.flake8 in this repo (I don't believe Ruff has complete coverage of every Pylint rule, but it's got a whole lot of them).

So, my proposal would be to go a bit further than #36 and either trim or remove entirely the other included linters/formatters.

@jsstevenson jsstevenson added the keep alive exempt issue from staleness checks label Mar 26, 2024
@korikuzma
Copy link
Contributor

@jsstevenson I like using ruff and would be fine only using it as our sole linter/formatter.

@jsstevenson
Copy link
Contributor

One other observation: the biocommons.org dev guide says that code style is enforced with black, isort, and pylint. However, the template also checks with flake8 in GitHub Actions and via pre-commit, but doesn't perform pylint checks in either case (although it is included as a dev dependency). It might be good to clean this up in one direction or another.

@korikuzma
Copy link
Contributor

@biocommons/maintainers have decided on dropping isort, pylint, and black in favor of ruff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep alive exempt issue from staleness checks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants