Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formulation of PMC in prefix map #1417

Closed
cthoyt opened this issue Nov 2, 2023 · 1 comment
Closed

Improve formulation of PMC in prefix map #1417

cthoyt opened this issue Nov 2, 2023 · 1 comment

Comments

@cthoyt
Copy link

cthoyt commented Nov 2, 2023

In biopragmatics/bioregistry#965, we got authoritative confirmation that PMC local unique identifiers should contain the PMC. Therefore, the following entry in the BioLink prefix map should be updated:

biolink-model/prefix-map/biolink-model-prefix-map.json

Line 147 in d9b97df

"PMC": "http://europepmc.org/articles/PMC",

Interestingly, there is also an adjacent line that doubles PMC prefix with PMCID that has the opposite opinion:

biolink-model/prefix-map/biolink-model-prefix-map.json

Line 148 in d9b97df

"PMCID": "http://www.ncbi.nlm.nih.gov/pmc/",

@cthoyt
Copy link
Author

cthoyt commented Nov 2, 2023

Oh, nice, this is a duplicate of #1366 and has already been solved by #1402. Cheers

@cthoyt cthoyt closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cthoyt