Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createInstructionSetBCHCHIPs uses isStandardOutputBytecode rather than isStandardOutputBytecode2023 #133

Open
rkalis opened this issue May 23, 2024 · 1 comment

Comments

@rkalis
Copy link
Contributor

rkalis commented May 23, 2024

It is my understanding that createInstructionSetBCHCHIPs should result in the most recent instruction set based on chipnet rules, which I'd expect to be further than BCH_2023. However, the BCH_CHIPS instruction set treats P2SH32 as non-standard output scripts. We ran into this while trying to debug a WalletTemplate scenario that sends to a P2SH32 locking bytecode.

See https://github.com/bitauth/libauth/blob/ade015123b2bfdbca721602cda19191c6f12252d/src/lib/vm/instruction-sets/bch/chips/bch-chips-instruction-set.ts#L697C16-L697C40

@bitjson
Copy link
Member

bitjson commented May 30, 2024

Thanks for the report @rkalis and @mr-zwets! This will be fixed in #134, it was just an oversight while merging CashTokens support (BCH_CHIP wasn't updated with some of the final changes). The linked PR creates BCH_2023_05, and proposed VMs for BCH_2025_05 and BCH_2026_05, as well as a BCH_SPEC which will serve as a long term testing ground for any mutually-compatible VM proposals (some explanation here).

I'm still deep in VM work, but I plan to merge and release #134 once I've finished implementing a few more types of benchmarks (and the learnings have made it into https://github.com/bitjson/bch-vm-limits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants