Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check unchecked arithmetic for externally provided values #1702

Open
notmandatory opened this issue Nov 14, 2024 · 1 comment
Open

Check unchecked arithmetic for externally provided values #1702

notmandatory opened this issue Nov 14, 2024 · 1 comment
Labels
audit Suggested as result of external code audit module-wallet

Comments

@notmandatory
Copy link
Member

"All across the crate, unchecked arithmetic is used. The unchecked arithmetic routines of rust-bitcoin's Amount type will panic if the result of an operation overflows. This is an issue for externally-provided values, such as for instance recipient amounts or fees"
@notmandatory notmandatory added audit Suggested as result of external code audit module-wallet labels Nov 14, 2024
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory moved this to Discussion in BDK Nov 14, 2024
@oleonardolima
Copy link
Contributor

I guess this is partially solved (if not fully -- needs checking) by #1763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Suggested as result of external code audit module-wallet
Projects
BDK
Status: Discussion
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notmandatory @oleonardolima