Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: [PSBT] Support Electrum bip32Derivation style #1664

Open
junderw opened this issue Jan 7, 2021 · 5 comments
Open

TODO: [PSBT] Support Electrum bip32Derivation style #1664

junderw opened this issue Jan 7, 2021 · 5 comments
Assignees
Labels

Comments

@junderw
Copy link
Member

junderw commented Jan 7, 2021

When Electrum doesn't know the masterFingerprint it uses the fingerprint of the xpub, and the path is from the xpub (as m)

Perhaps we could make this a separate method?

@junderw junderw self-assigned this Jan 7, 2021
@junderw junderw added the feature label Jan 7, 2021
@AndreasGassmann
Copy link

AndreasGassmann commented Apr 8, 2021

Is there an example available how this can be handled at the moment?

When working on PSBT integration I had a lot of trouble getting it to work. Turns out that this was the issue. I was not aware that electrum is not following the standard here. It's interesting that they still don't allow masterFingerprints to be imported by default. The only way I found is by using the integrated CLI, but that's not really feasible for regular users.

@junderw
Copy link
Member Author

junderw commented Apr 9, 2021

you have to check the bip32Derivation, derive the keys, and use sign

signHD doesn't support it yet.

@massimopavoni
Copy link

massimopavoni commented Jan 23, 2024

I know this is a rather old issue, but

The only way I found is by using the integrated CLI, but that's not really feasible for regular users.

@AndreasGassmann once imported the master fingerprint, is there a way of signing a transaction with Vault? It seems like it just doesn't recognize any of the Electrum generated QR codes.

@AndreasGassmann
Copy link

Is has been a long while, so I don't remember exactly anymore. But I'm pretty sure that when you import the masterFingerprint in Electrum, then it worked.

When you try it, what exactly didn't work? Maybe you can reach out on our social media channels so we can look into this.

@massimopavoni
Copy link

Essentially I tried to create a dummy transaction, that I wouldn't effectively broadcast afterwards, to see if I could sign it with the scanner in Vault, but the QR codes generated by Electrum, when scanned, trigger the incompatible code in the app. It does say I could "relay" it to the Wallet app, but I would rather keep my offline device with only one application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants