Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: use proper material theming #34

Open
macjohnny opened this issue Jun 6, 2018 · 0 comments
Open

Enhancement: use proper material theming #34

macjohnny opened this issue Jun 6, 2018 · 0 comments
Labels
feature New feature or request minor

Comments

@macjohnny
Copy link
Member

macjohnny commented Jun 6, 2018 •
edited
Loading

See #26 (comment)

the proper way would be to create a component theme similar to https://github.com/angular/material2/blob/master/src/lib/datepicker/_datepicker-theme.scss#L28 and require the users to include the mixin in their global styles, see https://material.angular.io/guide/theming-your-components

this prevents issues like #33
@macjohnny macjohnny added feature New feature or request help wanted Extra attention is needed labels Jun 6, 2018
@macjohnny macjohnny mentioned this issue Jun 6, 2018
Closed
@macjohnny macjohnny added minor and removed help wanted Extra attention is needed labels Jan 8, 2019
@macjohnny macjohnny mentioned this issue May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macjohnny