Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number modifier to default configuration #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pearsonradu
Copy link

Description of the change

Update the default configuration to contain the number modifier. Currently, if you try to add the below sample the generator will fail saying number is an unknown modifier.

YAML

## @param test [string,number] A test value to represent a string or a number
test: ""

Output

Error: Unknown modifier: number for parameter test

Benefits

Allows consumers to use the number modifier without providing a custom configuration.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • [ x ] Version bumped in package.json and package-lock.json according to semver.
  • [ x ] New features are documented in the README.md
  • [ x ] New features contain a new test at the tests folder
  • [ x ] All tests pass running npm test

Signed-off-by: Pearson Radu <62548051+pearsonradu@users.noreply.github.com>
@pearsonradu
Copy link
Author

@fmulero can this be reviewed?

@pearsonradu
Copy link
Author

Bump. If this is reviewed I can rebase the changes to fix the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants