Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the token types names references into symbol #283

Open
4 tasks
0xneves opened this issue Apr 9, 2024 · 0 comments
Open
4 tasks

refactor: change the token types names references into symbol #283

0xneves opened this issue Apr 9, 2024 · 0 comments
Labels
enhancement New features help wanted Extra attention is needed hot task Doubled points in the reward table

Comments

@0xneves
Copy link
Contributor

0xneves commented Apr 9, 2024

Refactor Request

Describe the Refactor Request

We will find the name() function being used in multiple places across the dApp to refer to the ERC20 or ERC721 token name following the Metadata.sol standard by OpenZeppelin.

But when it comes to industry standards we always use the shorten version symbol() which is limited to usually 7 characters maximum, as described in the overall trading industry.

Describe Preferred Solution

Find where name() is being used to be displayed in the dApp and change for the corresponding symbol(). It will also be used when using Alchemy SDK. The return will return both name and symbol.

Remember to also add the prefix "$" in the symbol and uppercase the letters.

Definition of Done:

  • Refactor all name() usages into symbol().
  • Find Alchemy SDK usage of name and change for symbol.
  • Use $ as a prefix for symbol and force the letters into uppercase.
  • Test the application with erc20 and erc721 that has no image to be displayed to see with the symbol was applied.
@0xneves 0xneves added the enhancement New features label Apr 9, 2024
@0xneves 0xneves added this to Swaplace Apr 9, 2024
@github-project-automation github-project-automation bot moved this to 💡 Ideas in Swaplace Apr 9, 2024
@0xneves 0xneves added the hot task Doubled points in the reward table label Apr 19, 2024
@heronlancellot heronlancellot moved this from 💡 Ideas to 🔖 TODO in Swaplace May 17, 2024
@RafaDSan RafaDSan added the help wanted Extra attention is needed label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features help wanted Extra attention is needed hot task Doubled points in the reward table
Projects
Status: 🔖 TODO
Development

No branches or pull requests

2 participants