Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: searched ens name are not retrieving data #320

Open
heronlancellot opened this issue Apr 22, 2024 · 6 comments
Open

fix: searched ens name are not retrieving data #320

heronlancellot opened this issue Apr 22, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@heronlancellot
Copy link
Member

Bug Report

Swaplace version

230827e

Current behavior

image

  • wrapper.ens.eth

Expected behavior

Expected the right user name ens address & retrieve the right data from the user.

Steps to reproduce

Search an ens name and check if the tokens are the same, also in the OfferSummary are not the same name.

Related code

OfferSummary.tsx
SearchBar.tsx

@heronlancellot heronlancellot added the bug Something isn't working label Apr 22, 2024
@github-project-automation github-project-automation bot moved this to 💡 Ideas in Swaplace Apr 22, 2024
@heronlancellot heronlancellot moved this from 💡 Ideas to 🔖 TODO in Swaplace Apr 22, 2024
@0xneves
Copy link
Contributor

0xneves commented May 6, 2024

I think this error is related to the end point we are using, it is public and free so it might not be 100% synced with the correct ens state

@0xneves
Copy link
Contributor

0xneves commented May 20, 2024

Try to contact the dev at https://ensdata.net/

@heronlancellot heronlancellot self-assigned this May 31, 2024
@heronlancellot heronlancellot moved this from 🔖 TODO to 🛠️ In Progress in Swaplace May 31, 2024
@heronlancellot
Copy link
Member Author

@0xneves I'm checking this issue and it looks like we are using the lib "web3-eth-ens" import { ENS } from "web3-eth-ens" to retrieve the ens name address from the user.

I opened this draft PR to show the difference between the getOwner & getAddress..
Let's see it.

@heronlancellot heronlancellot moved this from 🛠️ In Progress to ✅ Done in Swaplace Jun 5, 2024
@heronlancellot
Copy link
Member Author

Closed by #384

@heronlancellot heronlancellot moved this from ✅ Done to 🛠️ In Progress in Swaplace Jun 5, 2024
@heronlancellot heronlancellot reopened this Jun 5, 2024
@heronlancellot
Copy link
Member Author

Reopened the issue because the solution in #384 still not working.

@heronlancellot heronlancellot removed their assignment Jun 24, 2024
@heronlancellot heronlancellot moved this from 🛠️ In Progress to 🔖 TODO in Swaplace Jun 24, 2024
@heronlancellot
Copy link
Member Author

Because of this problem we're creating an new issue to remove the .ens from the dApp to works fine without any difference-name-surprise

@heronlancellot heronlancellot self-assigned this Sep 19, 2024
@heronlancellot heronlancellot moved this from 🔖 TODO to 🛠️ In Progress in Swaplace Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🛠️ In Progress
Development

No branches or pull requests

2 participants