Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip invalid files #8

Open
bluebrown opened this issue Jun 21, 2023 · 1 comment
Open

skip invalid files #8

bluebrown opened this issue Jun 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@bluebrown
Copy link
Owner

bluebrown commented Jun 21, 2023 •
edited
Loading

Currently, a single invalid yaml file prevents all updates on a given repository. This is because the kio.LocalPackageReadWriter errors and has no option to continue, skipping the file.
@bluebrown bluebrown added the enhancement New feature or request label Jun 21, 2023
@bluebrown
Copy link
Owner Author

Perhaps there could be a boolean field on the package reader named skipInvalid. If this is true, the error could be "ignored" at https://github.com/kubernetes-sigs/kustomize/blob/9e42f8d57e285d1113d608895a2015cea9ad2b21/kyaml/kio/pkgio_reader.go#L281.

This would probably require creating a sentinel error in the byte reader to check against.

It also leaves the question open how to communicate the skipped file to the caller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bluebrown