Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty lines in arrays #87

Open
krzysztofrewak opened this issue Dec 13, 2022 · 0 comments
Open

Remove empty lines in arrays #87

krzysztofrewak opened this issue Dec 13, 2022 · 0 comments

Comments

@krzysztofrewak
Copy link
Member

krzysztofrewak commented Dec 13, 2022

We need to investigate why empty lines in aray aren't removed:

return [
    "default" => env("DB_CONNECTION", "mysql"),

    "connections" => [
        "sqlite" => [
            "driver" => "sqlite",
            "url" => env("DATABASE_URL"),
            "database" => env("DB_DATABASE", database_path("database.sqlite")),
            "prefix" => "",
            "foreign_key_constraints" => env("DB_FOREIGN_KEYS", true),
        ],
];

should be like here:

return [
    "default" => env("DB_CONNECTION", "mysql"),
    "connections" => [
        "sqlite" => [
            "driver" => "sqlite",
            "url" => env("DATABASE_URL"),
            "database" => env("DB_DATABASE", database_path("database.sqlite")),
            "prefix" => "",
            "foreign_key_constraints" => env("DB_FOREIGN_KEYS", true),
        ],
];

NoExtraBlankLines fixer should cover that, but it's not working for some reason.


    We need that space?

Originally posted by @kamilpiech97 in #86 (comment)

krzysztofrewak added a commit that referenced this issue Jun 11, 2024
* #87 - no empty lines after docblocks

* #101 - lowercased constants

* - caching and parallel running

* - dependencies hell

* - csf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant