Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump SonarAnalyzer.CSharp from 9.0.0.68202 to 9.9.0.77355 #277

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2023

Bumps SonarAnalyzer.CSharp from 9.0.0.68202 to 9.9.0.77355.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.9

Hello everyone!

This release is focused on improving the symbolic execution engine to increase the issue accuracy. We also deleted rule S2255 as its deprecation period came to an end.

Deleted Rules:

  • 7853 - Delete S2255 (Deprecated).

False Positives

  • 7859 - [C#, VB.NET] Fix S2589/S4158: Do not consider a collection not to be empty if a remove method was called.
  • 6158 - [C#, VB.NET] Fix S2259 FP: Recognize NotNull results of String methods

False Negatives

  • 7910 - [C#] Fix S112 FN: When using null-coalesce operator.
  • 7861 - [C#, VB.NET] Fix S4158 FN: If a collection is cleared, mark the collection as empty.
  • 7780 - [C#, VB.NET] Fix S2589 FN: Track numerical constant patterns.
  • 7704 - [C#, VB.NET] Fix FN S2583/S2589 when Equals is invoked with bool or number parameters.

Other improvements

  • Modify rule S3776 - Change the remediation cost from constant to analogous to the excess over the complexity threshold.
  • 7825 - Update RSPEC before the 9.9 release.

9.8

This release completes our effort to migrate all our symbolic execution rules from our old to our new engine: S2583 and S2589 are now migrated and see significant improvements. Also, they are now available for VB.NET. This being the last analyzer to migrate means that the engines don't run in parallel anymore, which significantly reduces analysis time.

On top of that, our TokenTypeAnalyzer got a rework, which also improves performance in terms of analysis time and memory usage.

This new release supports a new taxonomy for issues and hotspots that better reflects the characteristics of Clean Code.

New Rules

  • 7648 - [VB.NET] S2589: Boolean expressions should not be gratuitous
  • 7647 - [VB.NET] S2583: Conditionally executed code should be reachable

Improvements

  • 7646 - [C#] Migrate S2583/S2589 to the new Symbolic Execution engine (C#)
  • 7369 - [C#] UtilityAnalyzer: Move to a syntax based classification of identifiers in the token type utility analyzer
  • 7697, 7803 - Update RSPEC before 9.8 release

False Positives

  • 7789 - [C#] Fix S2583/S2589 FP: Do not raise when condition is in the body of a lock statement.
  • 2496 - [C#] Fix S2583,S2589 FP: with nullable struct - update symbolic execution engine
  • 5601 - [C#] Fix S2583 FP: Variable change not detected inside a loop
  • 5002 - [C#] Fix S2583 FP: Property pattern match in else-if condition
  • 4755 - [C#] Fix S2583 FP: When using nullable boolean in if-elseif-else.
  • 4559 - [C#] Fix S2583 FP: User-defined explicit/implicit casts
  • 3288 - [C#] Fix S2583 FP: Invocation argument constraints should be independent
  • 2411 - [C#] Fix S2583 FP: confusing message for Guid comparison - should trigger S2589 instead
  • 739 - [C#] Fix S2583 FP: Condition evaluates to constant - false positive when casting floating point numbers
  • 7489 - [C#] Fix S2589 FP: Deconstructing a tuple in foreach loop
  • 7096 - [C#] Fix S2589 FP: || and property patterns
  • 5221 - [C#] Fix S2589 FP with nullable value types

... (truncated)

Commits
  • a1541b1 SE: Fix S4158 FP: Interfaces are only half tracked (#7941)
  • 7f52a74 Revert "BUILD-3017 use tokens for JFrog Artifactory instead of api ke… (#7937)
  • 598c579 Update RSPEC before release (#7934)
  • 668e37d SE: Do not learn CollectionConstraints for untracked collections (#7933)
  • 9e6cc0d SE: Learn bool constraint from Equals when parameters are numerical values (#...
  • 28f2de5 SE: Fix constant number pattern logic (#7931)
  • dc72d9e Add reproducers for S1144 FN/FP (#7925)
  • 858a1da BUILD-3017 use tokens for JFrog Artifactory instead of api keys (#7919)
  • 86603cb Retrieve file path from pragma checksum (#7912)
  • 922d983 Fix S112 FN: When using null-coalesce operator (#7911)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 9.0.0.68202 to 9.9.0.77355.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@9.0.0.68202...9.9.0.77355)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Sep 11, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 17, 2023

Superseded by #280.

@dependabot dependabot bot closed this Sep 17, 2023
@dependabot dependabot bot deleted the dependabot/nuget/SonarAnalyzer.CSharp-9.9.0.77355 branch September 17, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants