Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to reflect autogen requirement #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ pet's pre-requisites.
**Stable release:**

```shell
$ tar zxvf pluto-0.11.4.tar.gz
$ cd pluto-0.11.4/
$ PLUTO_VERSION=0.12.0
$ tar zxvf pluto-${PLUTO_VERSION}.tar.gz
$ cd pluto-${PLUTO_VERSION}/
$ ./autogen.sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release package shouldn't require a user to generate/regenerate the build config. The user shouldn't even ideally need to have autoconf/automake to build pluto from a release package (as opposed to the git repo). Please drop ./autogen.sh - not including that step was intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I pull the latest release (0.12.0), then the build config (a configure file that I can run with ./configure) isn't present. This is why I added the ./autogen.sh step.

wget https://github.com/bondhugula/pluto/releases/download/0.12.0/pluto-0.12.0.tar.gz
tar xfvz pluto-0.12.0.tar.gz 
cd pluto-0.12.0/

$ ./configure [--with-clang-prefix=<clang install location>]
$ make
$ make test
Expand Down