-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Vale syntax checker should not set the PR in error #464
Comments
This is related to an issue in the Vale action that makes the workflow to fail. |
This link is about setting an action exit code, not the workflow exit code. What we would like is to set the workflow global status to neutral or something similar. This may not possible for now as well. |
ℹ️ Vale is disable in bonita-doc until we found a solution: bonitasoft/bonita-doc#2218 |
Still an issue that make reviewdo to fail, when we have big files with many errors/warnings:
|
Created an issue for Vale about this: |
I made a fix in the Vale action, and wanted to create a PR, but don't have (yet) the rights to do it. |
@jeromecambon to create the PR, you must first fork the vale-action repository, push your changes to this fork and then you will be able to create a PR targeting the vale-action repo from your fork. |
The issue errata-ai/vale-action#84 is not fixed for a while, so we can close this issue, since Vale has been disabled. |
Setting the right close reason. |
Vale syntax checker issue is not fixed for a while, so we need to cleanup Vale-related info. See bonitasoft/bonita-documentation-site#464
Currently, the Vale syntax checker we have enabled on the bonita-doc repository set the PR in error as soon as a Vale warning appears.
See this PR for instance.
The text was updated successfully, but these errors were encountered: