Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New asset-path default causing problems on Node #170

Open
Deraen opened this issue Aug 5, 2017 · 2 comments
Open

New asset-path default causing problems on Node #170

Deraen opened this issue Aug 5, 2017 · 2 comments

Comments

@Deraen
Copy link
Contributor

Deraen commented Aug 5, 2017

https://github.com/anmonteiro/lumo had problems with Boot-cljs 2.1

❯ boot test
Compiling ClojureScript...
• lumo_test/test_suite.js

;; ======================================================================
;; Testing with Node:

module.js:487
    throw err;
    ^

Error: Cannot find module '/home/juho/.boot/cache/tmp/home/juho/Source/lumo/a6t/3lgroc/lumo_test/lumo_test/test_suite.out/goog/bootstrap/nodejs.js'

Previously the default asset-path happened to be correct, due to bug in Boot-cljs: #156
Also related: 3cd7195

Manually setting :asset-path on boot-cljs-test fixes this. There might be bug at boot-cljs-test code: https://github.com/crisptrutski/boot-cljs-test/blob/master/src/crisptrutski/boot_cljs_test/utils.clj#L101 But there could be something wrong with boot-cljs test also as this broke between 2.0 and 2.1.

@Deraen
Copy link
Contributor Author

Deraen commented Aug 5, 2017

This does work:

(deftask test-node []
  (testing)
  (cljs :compiler-options {:optimizations :none
                           :main 'lumo.test-runner
                           :verbose true
                           ; :asset-path "main.out"
                           :compiler-stats true
                           :target :nodejs}) )

@Deraen
Copy link
Contributor Author

Deraen commented Aug 5, 2017

Breaks PhantomJS also:

~/Source/metosin/metosin-common master* 19s
❯ boot run-tests
Compiling ClojureScript...
• cljs_test/generated_test_suite.js

;; ======================================================================
;; Testing with Phantom:

ClojureScript could not load :main, did you forget to specify :asset-path?
ReferenceError: Can't find variable: goog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant