npm bootbox dist different from the master branch in github #865
francisloumendoza
started this conversation in
General
Replies: 2 comments
-
Probably. Been awhile since I pushed an update to npm. There's an issue (#862) that I want to address and then I'll push another release (no ETA, sorry). When that happens I'll try to make sure that npm gets updated as well. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Probably. Been awhile since I pushed an update to npm. There's an issue (#862) that I want to address and then I'll push another release (no ETA, sorry). When that happens I'll try to make sure that npm gets updated as well. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I compared the bootbox.js from the npm vs. what's on the master branch and they are different. I'm specifically looking at the changes on the deprecated jQuery. (e.g. on npm it is still using the deprecated codes "$.isFunction(options.onHide)" while on github master, its now changed to "typeof options.onHide === 'function'" )
On the notes on both files, it says
/*! @preserve
*/
Shouldn't it be version 6.0.1 or something?
Beta Was this translation helpful? Give feedback.
All reactions