Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item: remove .chunks_healthy, fixes #8559 #8568

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Nov 25, 2024

Well, it's not totally removed, some code in Item, archive and borg transfer --from-borg1 needs to stay in place, so that we can pick the CORRECT chunks list that is in .chunks_healthy for all-zero-replacement-chunk-patched items when transferring archives from borg1 to borg2 repos.

FUSE fs read: IOError or all-zero result

Other reads: TODO

Also fixes: #8562

Well, it's not totally removed, some code in Item, Archive and
borg transfer --from-borg1 needs to stay in place, so that we
can pick the CORRECT chunks list that is in .chunks_healthy
for all-zero-replacement-chunk-patched items when transferring
archives from borg1 to borg2 repos.

FUSE fs read: IOError or all-zero result

Other reads: TODO
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (a46131b) to head (960b601).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/borg/archiver/transfer_cmd.py 59.09% 7 Missing and 2 partials ⚠️
src/borg/archive.py 83.33% 0 Missing and 1 partial ⚠️
src/borg/archiver/compact_cmd.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8568      +/-   ##
==========================================
+ Coverage   81.82%   81.92%   +0.10%     
==========================================
  Files          74       74              
  Lines       13301    13254      -47     
  Branches     1960     1947      -13     
==========================================
- Hits        10883    10858      -25     
+ Misses       1755     1741      -14     
+ Partials      663      655       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

borg2: cosmetic bug in compact
1 participant