Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d20200109_HIRANO_PDB ports different in ports and data #243

Open
BernhardAhrens opened this issue Jun 29, 2022 · 2 comments
Open

d20200109_HIRANO_PDB ports different in ports and data #243

BernhardAhrens opened this issue Jun 29, 2022 · 2 comments
Assignees

Comments

@BernhardAhrens
Copy link

I think I have discovered an inconsistency in the d20200109_HIRANO_PDB dataset:

ds = csr_dataset("d20200109_HIRANO_PDB")

unique(ds$ports$CSR_PORT) # gives 0
unique(ds$data$CSR_PORT) # gives 1 2 3 4 5 6

To my mind, all ports should be referenced in ports, so that the user knows which CSR_MSMT_VAR they are looking at.

Thanks for putting this great effort together!

@bpbond
Copy link
Owner

bpbond commented Jul 2, 2022

Ah good catch @BernhardAhrens - thank you! I will fix.

@bpbond bpbond self-assigned this Jul 2, 2022
@bpbond
Copy link
Owner

bpbond commented Jul 2, 2022

Note to self: write an automated test to catch this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants