move global data and node selector out of the bpfcommon data struct #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 26.38% 26.36% -0.02%
==========================================
Files 75 75
Lines 5021 5112 +91
==========================================
+ Hits 1325 1348 +23
- Misses 3532 3600 +68
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anfredette
reviewed
Jun 4, 2024
apis/v1alpha1/kprobeProgram_types.go
Outdated
| // NodeSelector allows the user to specify which nodes to deploy the | ||
| // bpf program to. This field must be specified, to select all nodes | ||
| // use standard metav1.LabelSelector semantics and make it empty. | ||
| NodeSelector metav1.LabelSelector `json:"nodeselector"` |
There was a problem hiding this comment.
Is there a reason you didn't put these in a common struct in shared_types.go?
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
anfredette
reviewed
Jun 4, 2024
| @@ -149,11 +149,13 @@ spec: | |||
| items: | |||
| type: string | |||
| type: array | |||
| x-kubernetes-list-type: atomic | |||
There was a problem hiding this comment.
Did you do anything to cause this to change, or did it just happen when you regenerated the crds?
There was a problem hiding this comment.
Possibly due to an update in the tools. I think that's the default anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preq before defining new application CRD