Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquote splicing example issue #10

Open
kxygk opened this issue Mar 26, 2018 · 1 comment
Open

Unquote splicing example issue #10

kxygk opened this issue Mar 26, 2018 · 1 comment

Comments

@kxygk
Copy link

kxygk commented Mar 26, 2018

In Chapter 8, when explaining unquote splicing you change the macro arguments from 2 arguments to using a map and keywords. The example that follows is then incorrect (and doesn't run in my REPL)
https://github.com/braveclojure/cftbat-code/blob/master/08/code.clj#L231

This line should read instead
(code-critic {:good (1 + 1) :bad (+ 1 1)})

As far as I understand the argument change is unrelated to the unquote splicing and just makes things more confusing. Please correct me if I'm wrong :)

Thanks for the great book. I'm enjoying it a lot

@randallard
Copy link

I've been suggesting this book to a bunch of people... it's pretty great that I got this far before running into a code error... maybe this example could be fixed in the online version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants