Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SLF4J to version 2.0.x #2078

Open
devurandom opened this issue May 27, 2023 · 2 comments
Open

Update to SLF4J to version 2.0.x #2078

devurandom opened this issue May 27, 2023 · 2 comments

Comments

@devurandom
Copy link

Version 2.0.7 of SLF4J was released: https://www.slf4j.org/news.html

The latest released version of HikariCP, version 5.0.1, depends, for Java 11 and newer, on slf4j-api version 2.0.0-alpha1:
https://github.com/brettwooldridge/HikariCP/blob/HikariCP-5.0.1/pom.xml#L555-L566

Since mixing 2.0.x and 1.7.x slf4j-api versions is not supported (cf. https://www.slf4j.org/faq.html#changesInVersion200), it would be nice if HikariCP could update to a current, stable version of SLF4J.

@billrobertson42
Copy link

slf4j 2.x provides explicitly modularized jar files, and they also claim that v2 should be a drop in replacement for 1.x.

Is the reason that this ticket was closed to avoid causing chaos downstream?

Asking because I'm working on converting automatic jars to explicitly modularized ones, and I'm considering just excluding hikari's dependency on slf4j-api:1.x in favor of 2.x, and I'm curious to know if there is some technical reason why hikari does not depend on the newer versions.

@linghengqian
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants