From e178d9bd96d8475f0a67154e2f790eea64ad8dc3 Mon Sep 17 00:00:00 2001 From: Michelle Yan Date: Tue, 5 Nov 2024 10:09:27 -0800 Subject: [PATCH] trying a chatgpt fix --- .github/workflows/ci_test_package.yml | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci_test_package.yml b/.github/workflows/ci_test_package.yml index 7aa49bf9..63f895a5 100644 --- a/.github/workflows/ci_test_package.yml +++ b/.github/workflows/ci_test_package.yml @@ -173,6 +173,8 @@ jobs: integration-sqlserver: strategy: fail-fast: false # Don't fail one DWH if the others fail + matrix: + version: ["1_3_0", "1_4_0", "1_7_0", "1_8_0"] runs-on: ubuntu-latest environment: name: Approve Integration Tests @@ -207,13 +209,12 @@ jobs: - name: Run Tests on PR env: DBT_VERSION: ${{ matrix.version }} - run: tox -e integration_sqlserver + run: tox -e integration_sqlserver_${{ matrix.version }} integration-sqlserver-single-run: strategy: - fail-fast: false # Don't fail one DWH if the others fail + fail-fast: false # Don't fail one DWH if the others fail matrix: - # When supporting a new version, update the list here version: ["1_3_0", "1_4_0", "1_7_0", "1_8_0"] runs-on: ubuntu-latest environment: @@ -232,21 +233,18 @@ jobs: - name: Create DBT User shell: pwsh run: | - echo "Create dbt login with sysadmin" - sqlcmd -Q "CREATE LOGIN dbt WITH PASSWORD = '123', CHECK_POLICY = OFF, CHECK_EXPIRATION = OFF" -d "dbt_artifact_integrationtests" - sqlcmd -Q "ALTER SERVER ROLE sysadmin ADD MEMBER dbt" -d "dbt_artifact_integrationtests" + echo "Create dbt login with sysadmin" + sqlcmd -Q "CREATE LOGIN dbt WITH PASSWORD = '123', CHECK_POLICY = OFF, CHECK_EXPIRATION = OFF" -d "dbt_artifact_integrationtests" + sqlcmd -Q "ALTER SERVER ROLE sysadmin ADD MEMBER dbt" -d "dbt_artifact_integrationtests" - name: Install tox run: python3 -m pip install tox - - name: Install Microsoft ODBC run: sudo ACCEPT_EULA=Y apt-get install msodbcsql18 -y - - name: Checkout uses: actions/checkout@v3 with: - ref: ${{ github.event.pull_request.head.sha }} # Check out the code of the PR - + ref: ${{ github.event.pull_request.head.sha }} # Check out the code of the PR - name: Run Tests on PR env: DBT_VERSION: ${{ matrix.version }} - run: tox -e integration_sqlserver_${{ matrix.version }} + run: tox -e integration_sqlserver_${{ matrix.version }}