Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Model Upload with incorrect column ordering #393

Merged

Conversation

il-dat
Copy link
Contributor

@il-dat il-dat commented Oct 3, 2023

Overview

Update get_column_name_lists.sql to get aligned with model.sql's column orders #392

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Solve #392

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@il-dat il-dat temporarily deployed to Approve Integration Tests October 3, 2023 03:44 — with GitHub Actions Inactive
@il-dat il-dat temporarily deployed to Approve Integration Tests October 3, 2023 03:44 — with GitHub Actions Inactive
@il-dat il-dat temporarily deployed to Approve Integration Tests October 3, 2023 03:44 — with GitHub Actions Inactive
@il-dat il-dat had a problem deploying to Approve Integration Tests October 3, 2023 03:44 — with GitHub Actions Failure
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this, and for fixing it.

@glsdown glsdown merged commit 039004a into brooklyn-data:main Oct 3, 2023
4 of 5 checks passed
@il-dat
Copy link
Contributor Author

il-dat commented Oct 5, 2023

Hi @glsdown Can I please check when the fix will get released? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants