-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Bugsnag Source Map Upload Work With EAS Update #48
Comments
Hi @thorbenprimke - we have an item on our backlog to add support for EAS Update in the future. I don't have an exact timescale for that at the moment, but I'll make sure that we keep this thread updated on progress 👍 |
hey @luke-belton any news on this? EAS updates is now in GA and many more users are using it. if ETA is somewhat far away can you point us to documentation that we can use to develop a workaround in the meantime? |
+1 |
EAS update is now the "official" way to deploy updates to Expo apps. @luke-belton could you provide a workaround for us to use until this is ready? Hopefully this can get prioritized since it will impact almost every expo user going forward. |
agreed. i already posted above @luke-belton but this is a really huge issue for us right now and looking into the upload code provided in the repo it is a bit of a jungle of gradle and shell scripts across each platform. can you point us to a simple API call that can be made manually to get sourcemaps up on bugsnag? a CURL command? anything would be useful at this point. i can't see bugsnag being viable for expo users moving forward unless this is solved. edit: i see this is labelled as |
Hi all - thanks for your thoughts on this and apologies for the delayed update. There are still some ongoing discussions internally on how best to support this, as well as some potential constraints around the current We hope to resolve these and also provide a recommendation for a manual approach in the interim - I’ll do my best to get an update out on this thread as soon as possible, hopefully by the end of the week 👍 |
Hi - thanks for your patience on this. Currently, EAS Update doesn't have a hook that's suitable for getting a unique ID with each update. At this stage, we'd therefore recommend bumping your app version each time you run the
You can replace As stated above, we are looking to add official support for EAS Updates, which will hopefully be possible in the near future once it has a hook or similar that we can use to get what we need on each update. Let me know if you have any questions about this approach 👍 |
@luke-belton Not sure if it's the same issue or not but I'm using EAS Update with Expo Go and I tried to manually upload the source maps with the |
Hi @greis - apologies for the slow response on this. In my testing I've been able to get sourcemaps working as expected using the method outlined above, running the update in Expo Go. Could you possibly write into support@bugsnag.com with links to events in Bugsnag that are failing to map so that we can investigate this for you please? |
Hi @greis, have you managed to make any progress with this? Are you sourcemaps working as expected now? |
@luke-belton - just wanted to let you know that the snippet you shared seems to work as expected. I've used it for a few OTA updates and any new crashes show the expected stack traces. Thanks! |
I was very confused how to get source maps. The expo docs are very confusing on the topic (see expo/expo#19934) and the bugsnag docs say that we only get source maps for release builds whatever that means. The CLI supports dumping source maps already (see expo/eas-cli@7ebb547). Sentry makes this seemingly super easy and configurable (see https://docs.expo.dev/guides/using-sentry) so I hope bugsnag can adopt a similar approach and help out on the bugsnag expo docs. I will however try out the workaround suggested, which was very much appreciated :) |
Hi @kennethlynne. To try to add some clarity around the release/development distinction I believe it is covered here from an EAS build perspective. Hope that helps. |
Bumping since this has been open for about 2 years now. EAS Update creates hbc bundles with Expo SDK 50. While manually upload works, source maps are not applied since my guess is they are not js files any more. Any updates here in the last 2 years?? |
Unfortunately we do not have an update to share at this moment in time. This is still on our backlog to complete when priorities allow. Once we have more information to share we will be sure to update you via this thread. |
Description
I had to push a quick bug fix via EAS Update but now the source maps no longer work - or at least another runtime exception logged after the update does not have the sources mapped.
Describe the solution you'd like
When one runs
upload the source maps.
The text was updated successfully, but these errors were encountered: