Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose panicwrap parent/child process status detection #137

Open
nikcorg opened this issue Oct 2, 2020 · 3 comments
Open

Expose panicwrap parent/child process status detection #137

nikcorg opened this issue Oct 2, 2020 · 3 comments
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature

Comments

@nikcorg
Copy link

nikcorg commented Oct 2, 2020

I only recently discovered that calling bugsnag.Configure forks the current process. I'm (now) aware that it is mentioned in the documentation as a side note, but there is still I think a missing piece to the puzzle; detecting parent/child process status.

The example in the panicwrap library's README has a clear example including detecting whether a program is the parent or child. This is useful, as the parent should ostensibly act only as the monitor, not reserve any additional resources and let the child do all the work.

Currently this mechanism is hidden away by the bugsnag library. Because of that we've opted to disable the automatic panic detection, as it's useless in it's current form: Our program relies on unique resources, meaning the child process is doing nothing more than idling away, using up a chunk of memory for no purpose whatsoever, and in effect this means the panicwrap isn't working as intended.

As I find the automatic panic reporting an appealing feature and would value having it as part of our monitoring toolkit, I would highly appreciate if either bugsnag.Configure returned the parent/child status of the current process, or that a separate API was made available for this purpose.

@nikcorg nikcorg changed the title Panicwrap parent/child process status detection Expose panicwrap parent/child process status detection Oct 2, 2020
@nikcorg
Copy link
Author

nikcorg commented Oct 9, 2020

Any thoughts on my suggestion?

I'm not sure if you're the right person, to ping, sorry if you're not, but cc: @kattrali

@mattdyoung
Copy link

Hi @nikcorg

We'll need to give this some thought to decide on the best API, but in principle exposing the behavior more transparently is a reasonable request. This is now on our backlog to take a look at when resources allow.

@mattdyoung mattdyoung added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels Oct 12, 2020
@nikcorg
Copy link
Author

nikcorg commented Oct 15, 2020

Thanks for the update @mattdyoung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants