Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview --live workflow & messages #182

Open
1 of 2 tasks
scharrier opened this issue Nov 11, 2021 · 0 comments
Open
1 of 2 tasks

Preview --live workflow & messages #182

scharrier opened this issue Nov 11, 2021 · 0 comments
Assignees
@paulRbr
Labels
enhancement New feature or request

Comments

@scharrier
Copy link
Member

scharrier commented Nov 11, 2021 •
edited by paulRbr
Loading

2 feedbacks after using the -- live option (which is really great, btw 👏 ).

  • When we launch the preview command with --live, we do not start by generating a preview. We directly get this message:

    Waiting for changes on file /Users/sebastien/Dev/bump/doc/api/v1/openapi.v3.yml...... ⣯

    I think that we should start by generating a preview, display the preview URL, and then. wait for changes in the file. As a user, I was expecting something like this:

    * Let's render a preview on Bump... done
* Your preview is visible at: https://bump.sh/preview/fba0a2c0-cd1d-41c5-9c9d-ab77e52a9ce0 (Expires at 2021-11-11T18:25:11+01:00)
Waiting for changes on file /Users/sebastien/Dev/bump/doc/api/v1/openapi.v3.yml... ⣯

  • Also, it may be a good enhancement to display a message each time the file (and the preview) is updated, to inform the user that something is happening. I thought it wasn't working just because nothing new was written in my CLI.
@scharrier scharrier added the enhancement New feature or request label Nov 11, 2021
@paulRbr paulRbr self-assigned this Nov 16, 2021
paulRbr added a commit to paulRbr/cli that referenced this issue May 4, 2023
@paulRbr
preview: send a first preview after exectution of the command
83d33fc 
With the `preview --live` command we used to wait for some changes on
the target file before launching the preview.

With this PR we generate a first preview with the given file, THEN
wait for future changes on the file.

About bump-sh#182
@paulRbr paulRbr mentioned this issue May 4, 2023
Merged
paulRbr added a commit to paulRbr/cli that referenced this issue Oct 5, 2023
@paulRbr
preview: fix (again) the “live preview” feature
b2900ad 
This commit makes sure to only create one preview (the previous
tentative fix on live previews would create 1 preview, then a 2nd
preview, and then update that 2nd preview).

Follow-up to bump-sh#456 (cf bump-sh#182)
@paulRbr paulRbr mentioned this issue Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulRbr paulRbr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scharrier @paulRbr