Review comments

bytecodealliance · Nov 21, 2024 · 1239ffe · 1239ffe
1 parent be05367
commit 1239ffe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cranelift/codegen/src/ir/extname.rs b/cranelift/codegen/src/ir/extname.rs
@@ -208,7 +208,7 @@ impl<'a> fmt::Display for DisplayableExternalName<'a> {
             ExternalName::TestCase(testcase) => testcase.fmt(f),
             ExternalName::LibCall(lc) => write!(f, "%{lc}"),
             ExternalName::KnownSymbol(ks) => write!(f, "%{ks}"),
-            ExternalName::BackendIntrinsic(i) => write!(f, "%backend{i}"),
+            ExternalName::BackendIntrinsic(i) => write!(f, "%intrinsic{i}"),
         }
     }
 }
@@ -228,7 +228,7 @@ impl FromStr for ExternalName {
         }
 
         // Try to parse as a backend intrinsic
-        if let Some(n) = s.strip_prefix("backend") {
+        if let Some(n) = s.strip_prefix("intrinsic") {
             if let Ok(n) = n.parse() {
                 return Ok(Self::BackendIntrinsic(n));
             }

diff --git a/cranelift/codegen/src/isa/pulley_shared/abi.rs b/cranelift/codegen/src/isa/pulley_shared/abi.rs
@@ -542,7 +542,7 @@ where
     }
 
     fn gen_call(dest: &CallDest, tmp: Writable<Reg>, info: CallInfo<()>) -> SmallVec<[Self::I; 2]> {
-        // Backend intrinsics for the pulley backend are use to implement the
+        // Backend intrinsics for the pulley backend are used to implement the
         // `call_indirect_host` opcode in Pulley.
         if let CallDest::ExtName(name @ ir::ExternalName::BackendIntrinsic(_), RelocDistance::Far) =
             dest

diff --git a/cranelift/filetests/filetests/isa/pulley64/call_indirect_host.clif b/cranelift/filetests/filetests/isa/pulley64/call_indirect_host.clif
@@ -2,7 +2,7 @@ test compile precise-output
 target pulley64
 
 function %call_indirect_host() {
-  fn0 = %backend0() system_v
+  fn0 = %intrinsic0() system_v
 block0:
   call fn0()
   return