Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important internal optimizations, potential bug #39

Open
calebwin opened this issue Apr 9, 2020 · 0 comments
Open

Important internal optimizations, potential bug #39

calebwin opened this issue Apr 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@calebwin
Copy link
Owner

calebwin commented Apr 9, 2020 •
edited
Loading

There are several internal things that make Emu's performance potentially suboptimal. This issue is a place to discuss them.

  • wgpu::Device::poll is used here and right now it blocks in an async context. I'm not sure what the solution is but there is some discussion here.
  • right now, we use a different staging buffer for every DeviceBox. This should be replaced by some sort of global pool of staging buffers which is shared by all DeviceBoxs.

Edit: the Device::poll thing is probably not an optimization but a bug in the library
@calebwin calebwin added the enhancement New feature or request label Apr 9, 2020
@calebwin calebwin mentioned this issue Apr 11, 2020
Open
@calebwin calebwin changed the title Important internal optimizations Important internal optimizations, potential bug May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@calebwin