Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for peerDependency of react@^17.0.0 #125

Open
zizzle6717 opened this issue Oct 2, 2021 · 2 comments
Open

Support for peerDependency of react@^17.0.0 #125

zizzle6717 opened this issue Oct 2, 2021 · 2 comments

Comments

@zizzle6717
Copy link

Describe the feature

Expand peerDependency to also include react above v17

Motivation

Dependency tree error in latest versions of node/npm

@Dashue
Copy link

Dashue commented Mar 17, 2022

Encountering this as well, any update?

@AntonyF-Andreani
Copy link

AntonyF-Andreani commented Jan 28, 2023

I found this problem too, a possible fix to improve support also to React 18 must be:

https://github.com/callstack/react-theme-provider/blob/master/package.json#L54

Change to:

{
    "peerDependencies": {
        "react": "^16.3.0 || ^17.0.2 || ^18.0.0",
    }
}

also this with combination of issue #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants