Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred light/dark theme? #55

Open
cpboyd opened this issue Jun 14, 2019 · 2 comments
Open

Preferred light/dark theme? #55

cpboyd opened this issue Jun 14, 2019 · 2 comments

Comments

@cpboyd
Copy link

cpboyd commented Jun 14, 2019

Describe the feature

It'd be nice to automatically be able to accommodate a user's preferred light/dark theme preferences.

Perhaps, simplifying the check of uiMode && UI_MODE_NIGHT_MASK on Android and traitCollection.userInterfaceStyle on iOS.

These both have undefined/unspecified, light, and dark/night.

Unfortunately, the built-in react-native uiMode doesn't give this information.

Motivation

With iOS 13 and Android Q making this sort of theming more integrated (and Google and Apple's own apps supporting the ability to switch at the OS level), it'd be nice to automatically detect what theme the user wants.

I'd rather not force a user to fumble through app settings to configure the theme if they've already got an option to specify it at the OS level.

Related Issues

I didn't see any at first glance, but I may have missed them.

@hrutvikpatel
Copy link

@cpboyd do you know of any modules that do what you described above?

@cpboyd
Copy link
Author

cpboyd commented Aug 27, 2019

@hrutvikpatel I didn't see anything during a quick Google search before I created this issue.

I'm now working on a Flutter app. Flutter does have this functionality baked in for the Material widgets on Android (I haven't yet tested it on an iPhone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants