Gitlab integration #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! We likely won’t be able to review until early August |
|
@tmorrell any update here ? |
|
We've had some staffing changes, but it's on our list to review soon. Hopefully by the end of the month! One quick comment, it would be great to add some gitlab tests like https://github.com/caltechlibrary/iga/blob/develop/tests/test_github_mocks.py and https://github.com/caltechlibrary/iga/blob/develop/tests/test_github.py. Since we don't use gitlab at Caltech having tests is important to make sure we don't break anything. |
|
working on it. next commit within this week. |
|
added the pytest for gitlab. |
|
@tmorrell , added the pytest similar to github and github_mocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #42 #40
This allows gitlab integration.
Added CLI options:
Interface to gitlab is made in
gitlab.py.A comman inteferace that pass the info to gitlab or github is made, (githublab.py) , it calls gitlab.py if --gitlab is specified.
Aditonal: closes the rich optionhighlighter issue aswell.
Questions:
In cli help , the text says --account but that option is not there. The available option is --github-account.
Should we change to --account (as this will be not github/gitlab specicifc).
Also there are option --github-token and --github-repo , should this be changed to --git-token and --git-repo repectively. So that we will be NOT be github/gitlab specific.
Software environment
Please include the following information:
Checklist
Please check that the following have been done:
developor another branch and notmain