Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

No test suite #1

Open
jw35 opened this issue May 15, 2017 · 1 comment
Open

No test suite #1

jw35 opened this issue May 15, 2017 · 1 comment
Labels

Comments

@jw35
Copy link

jw35 commented May 15, 2017

This code doesn't have a test suite. This makes all changes risky, and makes it particularly difficult to be sure that changes won't break compatibility with currently-supported PHP versions. This in turn makes merging pull requests difficult and so slows the rate at which this can happen.

Fixing this is probably not an enormous amount of work. The Ucam WebAuth Java toolkit test suite might be an inspiration.

@jw35
Copy link
Author

jw35 commented May 22, 2017

There's now an extremely-minimal test suite (see PR #8) that does little more than check that the code compiles. Much better than nothing (especially in association with Travis-CI which is now running the test suite on every commit), but still far from good enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant