You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we hide the ComposedModal close icon using styles, but hiding the close button with styles can sometimes cause issues. Providing a property or a way to pass a custom close icon would help eliminate these issues.
Also, placing the children in the ModalHeader component above the close button causes a tab order issue (wrong hierarchical order). Please see the issue: 6523
The solution
Approach 1
Provide a property hasCloseIcon or hideCloseIcon to hide the close button
Move the children to below the close icon, and close the icon button to the top (as the first element in the header)
Approach 2
Remove the current close button and allow to pass a custom close button with children
Examples
No response
Application/PAL
Carbon for IBM Products
Business priority
Low Priority = release date is not dependent on fix or not upcoming
Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.
If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.
The problem
Currently, we hide the
ComposedModal
close icon using styles, but hiding the close button with styles can sometimes cause issues. Providing a property or a way to pass a custom close icon would help eliminate these issues.Also, placing the
children
in theModalHeader
component above the close button causes a tab order issue (wrong hierarchical order). Please see the issue: 6523The solution
Approach 1
hasCloseIcon
orhideCloseIcon
to hide the close buttonchildren
to below the close icon, and close the icon button to the top (as the first element in the header)Approach 2
children
Examples
No response
Application/PAL
Carbon for IBM Products
Business priority
Low Priority = release date is not dependent on fix or not upcoming
Available extra resources
carbon-design-system/ibm-products#6523
Code of Conduct
The text was updated successfully, but these errors were encountered: