Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: option to hide ComposedModal header close icon #18262

Open
1 task done
makafsal opened this issue Dec 18, 2024 · 1 comment
Open
1 task done

[Feature Request]: option to hide ComposedModal header close icon #18262

makafsal opened this issue Dec 18, 2024 · 1 comment

Comments

@makafsal
Copy link
Member

The problem

Currently, we hide the ComposedModal close icon using styles, but hiding the close button with styles can sometimes cause issues. Providing a property or a way to pass a custom close icon would help eliminate these issues.

Also, placing the children in the ModalHeader component above the close button causes a tab order issue (wrong hierarchical order). Please see the issue: 6523

Image

The solution

Approach 1

  1. Provide a property hasCloseIcon or hideCloseIcon to hide the close button
  2. Move the children to below the close icon, and close the icon button to the top (as the first element in the header)

Approach 2

  1. Remove the current close button and allow to pass a custom close button with children

Examples

No response

Application/PAL

Carbon for IBM Products

Business priority

Low Priority = release date is not dependent on fix or not upcoming

Available extra resources

carbon-design-system/ibm-products#6523

Code of Conduct

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant