Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-0108 - Inconsistent field name #949

Open
palas opened this issue Dec 16, 2024 · 1 comment · May be fixed by #951
Open

CIP-0108 - Inconsistent field name #949

palas opened this issue Dec 16, 2024 · 1 comment · May be fixed by #951
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.

Comments

@palas
Copy link

palas commented Dec 16, 2024 •
edited
Loading

I've noticed when addressing IntersectMBO/cardano-cli#906 that, while the schema identifies the hash algorithm here as "CIP-0008" (consistently with the CIP-0108 text), in this example, it is written in lowercase ("cip-0008"). We probably should make this consistent. And I imagine we should favour "CIP-0008". Alternatively, if we want to allow both representations, we may want to update the schema to reflect that.
@palas palas mentioned this issue Dec 16, 2024
Open
@rphair rphair added the Category: Metadata Proposals belonging to the 'Metadata' category. label Dec 16, 2024
@rphair
Copy link
Collaborator

rphair commented Dec 16, 2024

thanks @palas - I agree that CIP-0008 (all uppercase) is canonical and that this would be desirable to fix... but we should poll my co-editors @Ryun1 @perturbing @Crypto2099 in case there could be technical problems adjusting the schema.

In the meantime you are welcome to submit a pull request that changes this in the repository: and we would appreciate the help because otherwise this will likely remain as a TODO item for the editors.

palas added a commit to palas/CIPs that referenced this issue Dec 16, 2024
@palas
Ensure "CIP-0008" is in capital letters (address cardano-foundation#949)
51b1a46
@palas palas linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Metadata Proposals belonging to the 'Metadata' category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CIP-0108 | Ensure "CIP-0008" is in capital letters palas/CIPs
2 participants
@palas @rphair