Ember Data still makes request

[deanmraz]

Issue

• I'm still seeing a network request

Expected

• Retrieve the data from shoebox

Steps

1. I created a demo here https://github.com/deanmraz/ember-data-shoebox-demo
2. yarn install
3. ember serve
4. Visit localhost:4200 with network tab open

Observe

1. articles model gets requested.
2. <script type="fastboot/shoebox" id="shoebox-ember-data-store"> in html looks correct.

[MartinMalinda]

Is it a blocking promise or a background reload? Is the issue also present with shouldBackgroundReloadAll being set to false?

https://www.emberjs.com/api/ember-data/3.4/classes/DS.Adapter/methods/shouldBackgroundReloadAll?anchor=shouldBackgroundReloadAll

Overall this is an interesting problem. Background reload does not make much sense on first initial load, but is probably still desired on normal in-app transitions. So disabling it on first route visit might make sense, but I'm not aware of any super easy way of doing it.

I guess this also might not be a background reload problem and this is caused because Ember Data cannot tell findAll has previously been done just by retrieving models from shoebox.

[deanmraz]

I will try that out and get back to you, thanks!

…

On Fri, Sep 14, 2018 at 11:58 AM Martin Malinda ***@***.***> wrote: Is it a blocking promise or a background reload? Is the issue also present with shouldBackgroundReloadAll being set to false? https://www.emberjs.com/api/ember-data/3.4/classes/DS.Adapter/methods/shouldBackgroundReloadAll?anchor=shouldBackgroundReloadAll — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACt1u5AnFkW9EUvLsWzKzYjC7Qtmv2Yvks5ua_xtgaJpZM4WpxsE> .

[deanmraz]

@MartinMalinda that was it, does it make sense to throw this in the README.md?

[deanmraz]

Wanted to make sure I record this, because came back to the same issue in another project.

peekAll first to grab the cache records, but if none exist then run the query. For some reason shouldBackgroundReloadAll didn't work in the latest ember version 3.7. Also more control with this approach.

import Route from '@ember/routing/route';

export default Route.extend({
  model() {
    const collection = this.store.peekAll('article');
    if (collection.length === 0) {
      return this.store.query('article', {
        feed: 'latest',
      });
    }
    return collection;
  }
});