Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once QuickJS supports WeakRef, enable regular tests: #2199

Open
github-actions bot opened this issue Jul 22, 2024 · 2 comments
Open

Once QuickJS supports WeakRef, enable regular tests: #2199

github-actions bot opened this issue Jul 22, 2024 · 2 comments

Comments

@github-actions
Copy link

suspend fun detectImmediateCollection()
suspend fun detectDelayedCollection()
suspend fun detectLeak()


/*
 * Copyright (C) 2024 Square, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package app.cash.redwood.leaks.zipline

import app.cash.zipline.ZiplineService

interface LeakDetectorTestService : ZiplineService {
  fun leakDetectorDisabled()

  // TODO Once QuickJS supports WeakRef, enable regular tests:
  //  suspend fun detectImmediateCollection()
  //  suspend fun detectDelayedCollection()
  //  suspend fun detectLeak()

  companion object {
    const val SERVICE_NAME = "leakDetectorTest"
  }
}

@JakeWharton
Copy link
Collaborator

bellard/quickjs#337

@swankjesse
Copy link
Collaborator

Maybe we can use the FinalizationRegistry bindings in Zipline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants