We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, each method of as.hyperSpec() uses its own order, default values and number of arguments:
as.hyperSpec()
.as.hyperSpec.matrix <- function(X, wl = guess.wavelength(colnames(X)), ...) .as.hyperSpec.data.frame <- function(X, spc = NULL, wl = guess.wavelength(spc), labels = attr(X, "labels"), ...) .as.hyperSpec.hyperSpec <- function(X)
This makes it more difficult to use in other functions as each case should be addressed separately. My suggestions would be to:
NULL
wl
May also be related: #144 (comment)
The text was updated successfully, but these errors were encountered:
This is a very good point. +1
Sorry, something went wrong.
Moved and reopened as:
No branches or pull requests
Currently, each method of
as.hyperSpec()
uses its own order, default values and number of arguments:This makes it more difficult to use in other functions as each case should be addressed separately.
My suggestions would be to:
NULL
for the default values in the signature and perform calculations or real initial values inside the methods;wl
into the name that will be suggested in consistent naming of wavelength parameters #90.May also be related: #144 (comment)
The text was updated successfully, but these errors were encountered: